Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Tee to MessageId #1506

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Port Tee to MessageId #1506

merged 1 commit into from
Feb 28, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 27, 2024

Unfortunately Tee was hit the hardest by the MessageId refactors.
That said we are getting some extra benefit from this PR: we now process mismatches at the message level instead of the batch level.
This means messages will no longer fail due to unrelated messages in the same batch failing.
This was done in this PR since working with MessageId's requires working at the per message level.

@rukai rukai force-pushed the teeeeeee branch 5 times, most recently from c70040f to a4e11e5 Compare February 28, 2024 03:19
@rukai rukai marked this pull request as ready for review February 28, 2024 03:51
@rukai rukai requested a review from conorbros February 28, 2024 03:51
@rukai rukai merged commit 081d173 into shotover:main Feb 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants